Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding openid connect provider to enable irsa feature #1903

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

sblair-metrostar
Copy link
Contributor

@sblair-metrostar sblair-metrostar commented Aug 11, 2023

Reference Issues or PRs

Fixes #1896

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Added OIDC provider ARN and URL to module output(s) as this will be required in the creation of the trust policy for any downstream roles attempting to use this feature.

@pavithraes pavithraes added the needs: review 👀 This PR is complete and ready for reviewing label Aug 14, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Thanks @sblair-metrostar!

@iameskild iameskild merged commit 0a0e988 into nebari-dev:develop Aug 30, 2023
8 checks passed
@Adam-D-Lewis Adam-D-Lewis mentioned this pull request May 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: k8s ⎈ needs: review 👀 This PR is complete and ready for reviewing provider: AWS
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Enable IRSA on Nebari AWS deployments
4 participants